HIVE-29383: Iceberg: [V3] Add support for timestamp with nanosecond precession #6258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
ayushtkn
force-pushed
the
HIVE-29383_2
branch
from
2381504 to
067bd55
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
ayushtkn
force-pushed
the
HIVE-29383_2
branch
from
067bd55 to
bd4a90f
Compare
ayushtkn
changed the title
difin
reviewed
Jan 22, 2026
Comment on lines
506
to
518
| } else if (params != null && params.length > 1) { | ||
| throw new IllegalArgumentException( | ||
| "Timestamp takes only one parameter, but " + params.length + " is seen"); | ||
| } | ||
| return TypeInfoFactory.getTimestampTypeInfo(prec); | ||
| case TIMESTAMPLOCALTZ: | ||
| int precTimeZone = 6; | ||
| if (params != null && params.length == 1) { | ||
| precTimeZone = Integer.parseInt(params[0]); | ||
| } else if (params != null && params.length > 1) { | ||
| throw new IllegalArgumentException( | ||
| "Timestamp takes only one parameter, but " + params.length + " is seen"); | ||
| } |
Contributor
There was a problem hiding this comment.
These lines are duplicated in 2 places in this block of code, should they be extracted into a helper method?
if (params != null && params.length > 1) {
throw new IllegalArgumentException(
"Timestamp takes only one parameter, but " + params.length + " is seen");
}
difin
reviewed
Jan 22, 2026
| super(serdeConstants.TIMESTAMPLOCALTZ_TYPE_NAME); | ||
| this.timeZone = TimestampTZUtil.parseTimeZone(timeZoneStr); | ||
| if (precision != 6 && precision != 9) { | ||
| throw new RuntimeException("Unsupported value for precision: " + precision); |
Contributor
There was a problem hiding this comment.
The same exception error message is reused in TimestampTypeInfo constructor, should we define a common error message in ErrorMsg for reuse?
difin
approved these changes
Jan 22, 2026
Contributor
difin
left a comment
difin
left a comment
There was a problem hiding this comment.
LGTM +1
Left 2 comments about some minor code duplication.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for Iceberg Nanosecond Timestamp
Why are the changes needed?
To support the new V3 Nanosecond Timestamp
Does this PR introduce any user-facing change?
yes, users can create iceberg v3 table with nanosecond timestamp precession.
How was this patch tested?
UT + Docker With Iceberg master(Which includes bug fixes for multiple issues regarding nanosecond timestamp)